Commit 649c3fed authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

eth: bnxt: fix the wake condition 

The down condition should be the negation of the wake condition,
IOW when I moved it from:

 if (cond && wake())
to
 if (__netif_txq_completed_wake(cond))

Cond should have been negated. Flip it now.

This bug leads to occasional crashes with netconsole.
It may also lead to queue never waking up in case BQL is not enabled.

Reported-by: David Wei <davidhwei@meta.com>
Fixes: 08a096780d92 ("bnxt: use new queue try_stop/try_wake macros")
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Link: https://lore.kernel.org/r/20230607010826.960226-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
parent c9d99cfa

drivers/net/ethernet/broadcom/bnxt/bnxt.c

+1 −1
Original line number Diff line number Diff line
@@ -692,7 +692,7 @@ static void bnxt_tx_int(struct bnxt *bp, struct bnxt_napi *bnapi, int nr_pkts) 


	__netif_txq_completed_wake(txq, nr_pkts, tx_bytes,

				   bnxt_tx_avail(bp, txr), bp->tx_wake_thresh,

				   READ_ONCE(txr->dev_state) != BNXT_DEV_STATE_CLOSING);

				   READ_ONCE(txr->dev_state) == BNXT_DEV_STATE_CLOSING);

}



static struct page *__bnxt_alloc_rx_page(struct bnxt *bp, dma_addr_t *mapping,