Commit 64bf2747 authored by Heiner Kallweit's avatar Heiner Kallweit Committed by Greg Kroah-Hartman
Browse files

eeprom: ee1004: Remove not needed check in ee1004_eeprom_read 



i2c_smbus_read_i2c_block_data_or_emulated() checks its length argument,
so we don't have to do it. In addition remove the unlikely hint from
the checks, we do i2c reads and therefore are in a slow path.

Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Link: https://lore.kernel.org/r/eb2a8bff-43ec-c763-a417-9d741e6f0034@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7abdadfc

drivers/misc/eeprom/ee1004.c

+1 −3
Original line number Diff line number Diff line
@@ -76,10 +76,8 @@ static ssize_t ee1004_eeprom_read(struct i2c_client *client, char *buf, 
{

	int status;



	if (count > I2C_SMBUS_BLOCK_MAX)

		count = I2C_SMBUS_BLOCK_MAX;

	/* Can't cross page boundaries */

	if (unlikely(offset + count > EE1004_PAGE_SIZE))

	if (offset + count > EE1004_PAGE_SIZE)

		count = EE1004_PAGE_SIZE - offset;



	status = i2c_smbus_read_i2c_block_data_or_emulated(client, offset,