Commit 6544c672 authored by Fabio Aiuto's avatar Fabio Aiuto Committed by Greg Kroah-Hartman
Browse files

staging: rtl8723bs: remove commented out RT_TRACE logs in hal/ and os_dep/ 



Remove all commented out TR_TRACE calls.

Remove all of the RT_TRACE logs in hal/ and os_dep/ file as they
currently do nothing as they require the code to be modified by
hand in order to be turned on. This obviously has not happened
since the code was merged. Moreover it relies on an unneeded
private log level tracing which overrides the in-kernel public one,
so just remove them as they are unused.

Suggested-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarFabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/85338f2b2cffb530efbd987064d146fc2be49c72.1617640221.git.fabioaiuto83@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c1314fe4

drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c

+0 −3
Original line number Diff line number Diff line
@@ -1847,7 +1847,6 @@ void PHY_IQCalibrate_8723B( 
				bResult = FAIL;

				break;

			}

			/* RT_TRACE(_module_mp_, _drv_notice_, ("Switch to S1 TxIQC(offset, data) = (0x%X, 0x%X)\n", offset, data)); */

			PHY_SetBBReg(pDM_Odm->Adapter, offset, bMaskDWord, data);

		}
@@ -1864,7 +1863,6 @@ void PHY_IQCalibrate_8723B( 
				bResult = FAIL;

				break;

			}

			/* RT_TRACE(_module_mp_, _drv_notice_, ("Switch to S1 RxIQC (offset, data) = (0x%X, 0x%X)\n", offset, data)); */

			PHY_SetBBReg(pDM_Odm->Adapter, offset, bMaskDWord, data);

		}
@@ -1950,7 +1948,6 @@ void PHY_IQCalibrate_8723B( 
			}

		}

	}

/* 	RT_TRACE(COMP_INIT, DBG_LOUD, ("Release Mutex in IQCalibrate\n")); */



	for (i = 0; i < 4; i++) {

		RegE94 = result[i][0];

drivers/staging/rtl8723bs/hal/hal_com_phycfg.c

+0 −1
Original line number Diff line number Diff line
@@ -1785,7 +1785,6 @@ s8 phy_get_tx_pwr_lmt(struct adapter *adapter, u32 reg_pwr_tbl_sel, 
	/*

	if (band_type == BAND_ON_5G && pwr_lmt == MAX_POWER_INDEX) {

		if (idx_bandwidth == 0 || idx_bandwidth == 1) {

			RT_TRACE(COMP_INIT, DBG_LOUD, ("No power limit table of the specified band %d, bandwidth %d, ratesection %d, rf path %d\n",

				 idx_band, idx_bandwidth,

				 idx_rate_sctn, rf_path));

			if (idx_rate_sctn == 2)

drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c

+0 −8
Original line number Diff line number Diff line
@@ -2583,7 +2583,6 @@ void Hal_EfuseParseEEPROMVer_8723B( 
{

	struct hal_com_data	*pHalData = GET_HAL_DATA(padapter);



/* 	RT_TRACE(_module_hci_hal_init_c_, _drv_notice_, ("%s(): AutoLoadFail = %d\n", __func__, AutoLoadFail)); */

	if (!AutoLoadFail)

		pHalData->EEPROMVersion = hwinfo[EEPROM_VERSION_8723B];

	else
@@ -2662,7 +2661,6 @@ void Hal_EfuseParseCustomerID_8723B( 
{

	struct hal_com_data	*pHalData = GET_HAL_DATA(padapter);



/* 	RT_TRACE(_module_hci_hal_init_c_, _drv_notice_, ("%s(): AutoLoadFail = %d\n", __func__, AutoLoadFail)); */

	if (!AutoLoadFail)

		pHalData->EEPROMCustomerID = hwinfo[EEPROM_CustomID_8723B];

	else
@@ -2683,7 +2681,6 @@ void Hal_EfuseParseXtal_8723B( 
{

	struct hal_com_data	*pHalData = GET_HAL_DATA(padapter);



/* 	RT_TRACE(_module_hci_hal_init_c_, _drv_notice_, ("%s(): AutoLoadFail = %d\n", __func__, AutoLoadFail)); */

	if (!AutoLoadFail) {

		pHalData->CrystalCap = hwinfo[EEPROM_XTAL_8723B];

		if (pHalData->CrystalCap == 0xFF)
@@ -2699,7 +2696,6 @@ void Hal_EfuseParseThermalMeter_8723B( 
{

	struct hal_com_data *pHalData = GET_HAL_DATA(padapter);



/* 	RT_TRACE(_module_hci_hal_init_c_, _drv_notice_, ("%s(): AutoLoadFail = %d\n", __func__, AutoLoadFail)); */

	/*  */

	/*  ThermalMeter from EEPROM */

	/*  */
@@ -3001,8 +2997,6 @@ static void rtl8723b_fill_default_txdesc( 


		ptxdesc->usb_txagg_num = pxmitframe->agg_num;

	} else if (pxmitframe->frame_tag == MGNT_FRAMETAG) {

/* 		RT_TRACE(_module_hal_xmit_c_, _drv_notice_, ("%s: MGNT_FRAMETAG\n", __func__)); */



		ptxdesc->macid = pattrib->mac_id; /*  CAM_ID(MAC_ID) */

		ptxdesc->qsel = pattrib->qsel;

		ptxdesc->rate_id = pattrib->raid; /*  Rate ID */
@@ -3776,9 +3770,7 @@ void SetHwReg8723B(struct adapter *padapter, u8 variable, u8 *val) 
				ulCommand = ulCommand | CAM_POLLINIG | CAM_WRITE;

				/*  write content 0 is equall to mark invalid */

				rtw_write32(padapter, WCAMI, ulContent);  /* mdelay(40); */

				/* RT_TRACE(COMP_SEC, DBG_LOUD, ("CAM_empty_entry(): WRITE A4: %lx\n", ulContent)); */

				rtw_write32(padapter, RWCAM, ulCommand);  /* mdelay(40); */

				/* RT_TRACE(COMP_SEC, DBG_LOUD, ("CAM_empty_entry(): WRITE A0: %lx\n", ulCommand)); */

			}

		}

		break;

drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c

+0 −2
Original line number Diff line number Diff line
@@ -74,7 +74,6 @@ void PHY_RF6052SetBandwidth8723B( 
		break;



	default:

		/* RT_TRACE(COMP_DBG, DBG_LOUD, ("PHY_SetRF8225Bandwidth(): unknown Bandwidth: %#X\n", Bandwidth)); */

		break;

	}
@@ -153,7 +152,6 @@ static int phy_RF6052_Config_ParaFile(struct adapter *Adapter) 


	ODM_ConfigRFWithTxPwrTrackHeaderFile(&pHalData->odmpriv);



	/* RT_TRACE(COMP_INIT, DBG_LOUD, ("<---phy_RF6052_Config_ParaFile()\n")); */

	return _SUCCESS;

}

drivers/staging/rtl8723bs/os_dep/ioctl_linux.c

+0 −6
Original line number Diff line number Diff line
@@ -4178,7 +4178,6 @@ static int rtw_wx_set_priv(struct net_device *dev, 
	struct adapter *padapter = rtw_netdev_priv(dev);

	struct iw_point *dwrq = (struct iw_point *)awrq;



	/* RT_TRACE(_module_rtl871x_ioctl_os_c, _drv_notice_, ("+rtw_wx_set_priv\n")); */

	if (dwrq->length == 0)

		return -EFAULT;
@@ -4192,11 +4191,6 @@ static int rtw_wx_set_priv(struct net_device *dev, 
		return -EFAULT;

	}





	/* RT_TRACE(_module_rtl871x_ioctl_os_c, _drv_notice_, */

	/* 	 ("rtw_wx_set_priv: %s req =%s\n", */

	/* 	  dev->name, ext)); */



	#ifdef DEBUG_RTW_WX_SET_PRIV

	ext_dbg = vmalloc(len);

	if (!ext_dbg) {