Commit 65b27281 authored by Markus Elfring's avatar Markus Elfring Committed by Greg Kroah-Hartman
Browse files

coresight: cti: Reduce scope for the variable 'cs_fwnode' in cti_plat_create_connection() 

A local variable was used only within an else branch.
Thus move the definition for the variable “cs_fwnode” into
the corresponding code block.

This issue was detected by using the Coccinelle software.

Link: https://lore.kernel.org/r/c1b09b27-9012-324f-28d0-ba820dc468a5@web.de


Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
Link: https://lore.kernel.org/r/20210201181351.1475223-2-mathieu.poirier@linaro.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 11a0b5e0

drivers/hwtracing/coresight/coresight-cti-platform.c

+3 −3
Original line number Diff line number Diff line
@@ -343,7 +343,6 @@ static int cti_plat_create_connection(struct device *dev, 
{

	struct cti_trig_con *tc = NULL;

	int cpuid = -1, err = 0;

	struct fwnode_handle *cs_fwnode = NULL;

	struct coresight_device *csdev = NULL;

	const char *assoc_name = "unknown";

	char cpu_name_str[16];
@@ -397,8 +396,9 @@ static int cti_plat_create_connection(struct device *dev, 
		assoc_name = cpu_name_str;

	} else {

		/* associated device ? */

		cs_fwnode = fwnode_find_reference(fwnode,

						  CTI_DT_CSDEV_ASSOC, 0);

		struct fwnode_handle *cs_fwnode = fwnode_find_reference(fwnode,

									CTI_DT_CSDEV_ASSOC,

									0);

		if (!IS_ERR(cs_fwnode)) {

			assoc_name = cti_plat_get_csdev_or_node_name(cs_fwnode,

								     &csdev);