Commit 6794ed0c authored by Marco Pagani's avatar Marco Pagani Committed by Jonathan Cameron
Browse files

iio: adc: xilinx-ams: fix devm_krealloc() return value check 



The clang-analyzer reported a warning: "Value stored to 'ret'
is never read".

Fix the return value check if devm_krealloc() fails to resize
ams_channels.

Fixes: d5c70627 ("iio: adc: Add Xilinx AMS driver")
Signed-off-by: default avatarMarco Pagani <marpagan@redhat.com>
Acked-by: default avatarMichal Simek <michal.simek@amd.com>
Link: https://lore.kernel.org/r/20221125113112.219290-1-marpagan@redhat.com


Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent cbd3a015

drivers/iio/adc/xilinx-ams.c

+1 −1
Original line number Diff line number Diff line
@@ -1329,7 +1329,7 @@ static int ams_parse_firmware(struct iio_dev *indio_dev) 


	dev_channels = devm_krealloc(dev, ams_channels, dev_size, GFP_KERNEL);

	if (!dev_channels)

		ret = -ENOMEM;

		return -ENOMEM;



	indio_dev->channels = dev_channels;

	indio_dev->num_channels = num_channels;