Skip to content
Commit 67974231 authored by Ion Badulescu's avatar Ion Badulescu Committed by Jeff Garzik
Browse files

[netdrvr starfire] fix highmem and broken firmware issues



Unfortunately, [your patch] might address the crash but doesn't address
the real problem. It turns out that the problem is one of padding
(the firmware cksum engine works only on 32-bit chunks, yuck), so
the special casing for length == 1 wasn't sufficient anyway.

This patch addresses the issue, as well the other issue of i386 +
CONFIG_HIGHMEM being broken. It is pretty much the same workaround
that Adaptec themselves used in their Windows driver. I have yet to
check if it fixes the problem when the skb is non-linear, but this
patch _will_ solve the problem for 99% of the users out there (those
not using sendfile).

Signed-off-by: default avatarIon Badulescu <ionut@badula.org>
Signed-off-by: default avatarJeff Garzik <jgarzik@pobox.com>
parent 32fa2bfc
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment