Commit 6854a105 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Lee Jones
Browse files

mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type 



Interrupt line can be configured on different hardware in different way,
even inverted.  Therefore driver should not enforce specific trigger
type - edge falling - but instead rely on Devicetree to configure it.

The Samsung PMIC drivers are used only on Devicetree boards.

Additionally, the PMIC datasheets describe the interrupt line as active
low with a requirement of acknowledge from the CPU therefore the edge
falling is not correct.

Marek Szyprowski reports that together with DTS change (proper level in
DTS) it fixes RTC alarm failure that he observed from time to time on
TM2e board.

Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Tested-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20210602110445.33536-1-krzysztof.kozlowski@canonical.com
parent b147a055

drivers/mfd/sec-irq.c

+1 −2
Original line number Diff line number Diff line
@@ -479,8 +479,7 @@ int sec_irq_init(struct sec_pmic_dev *sec_pmic) 
	}



	ret = devm_regmap_add_irq_chip(sec_pmic->dev, sec_pmic->regmap_pmic,

				       sec_pmic->irq,

				       IRQF_TRIGGER_FALLING | IRQF_ONESHOT,

				       sec_pmic->irq, IRQF_ONESHOT,

				       0, sec_irq_chip, &sec_pmic->irq_data);

	if (ret != 0) {

		dev_err(sec_pmic->dev, "Failed to register IRQ chip: %d\n", ret);