Commit 68a6e0c6 authored by Yang Yingliang's avatar Yang Yingliang Committed by Marc Zyngier
Browse files

irqchip/mchp-eic: Fix return value check in mchp_eic_init() 



In case of error, the function of_iomap() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.

Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Reviewed-by: default avatarClaudiu Beznea <claudiu.beznea@microchip.com>
Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20211025050055.1129845-1-yangyingliang@huawei.com
parent 00fa3461

drivers/irqchip/irq-mchp-eic.c

+1 −1
Original line number Diff line number Diff line
@@ -209,7 +209,7 @@ static int mchp_eic_init(struct device_node *node, struct device_node *parent) 
		return -ENOMEM;



	eic->base = of_iomap(node, 0);

	if (IS_ERR(eic->base)) {

	if (!eic->base) {

		ret = -ENOMEM;

		goto free;

	}