Commit 68d9787b authored by Manivannan Sadhasivam's avatar Manivannan Sadhasivam Committed by Mathieu Poirier
Browse files

remoteproc: Don't bother checking the return value of debugfs_create* 



DebugFS APIs are designed to return only the error pointers and not NULL
in the case of failure. So these return pointers are safe to be passed on
to the successive debugfs_create* APIs.

Therefore, let's just get rid of the checks.

Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/20220329154616.58902-1-manivannan.sadhasivam@linaro.org


Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
parent f20e232d

drivers/remoteproc/remoteproc_core.c

+0 −4
Original line number Diff line number Diff line
@@ -684,10 +684,6 @@ static int rproc_handle_trace(struct rproc *rproc, void *ptr, 


	/* create the debugfs entry */

	trace->tfile = rproc_create_trace_file(name, rproc, trace);

	if (!trace->tfile) {

		kfree(trace);

		return -EINVAL;

	}



	list_add_tail(&trace->node, &rproc->traces);

drivers/remoteproc/remoteproc_debugfs.c

+2 −15
Original line number Diff line number Diff line
@@ -386,16 +386,8 @@ void rproc_remove_trace_file(struct dentry *tfile) 
struct dentry *rproc_create_trace_file(const char *name, struct rproc *rproc,

				       struct rproc_debug_trace *trace)

{

	struct dentry *tfile;



	tfile = debugfs_create_file(name, 0400, rproc->dbg_dir, trace,

	return debugfs_create_file(name, 0400, rproc->dbg_dir, trace,

				    &trace_rproc_ops);

	if (!tfile) {

		dev_err(&rproc->dev, "failed to create debugfs trace entry\n");

		return NULL;

	}



	return tfile;

}



void rproc_delete_debug_dir(struct rproc *rproc)
@@ -411,8 +403,6 @@ void rproc_create_debug_dir(struct rproc *rproc) 
		return;



	rproc->dbg_dir = debugfs_create_dir(dev_name(dev), rproc_dbg);

	if (!rproc->dbg_dir)

		return;



	debugfs_create_file("name", 0400, rproc->dbg_dir,

			    rproc, &rproc_name_ops);
@@ -430,11 +420,8 @@ void rproc_create_debug_dir(struct rproc *rproc) 


void __init rproc_init_debugfs(void)

{

	if (debugfs_initialized()) {

	if (debugfs_initialized())

		rproc_dbg = debugfs_create_dir(KBUILD_MODNAME, NULL);

		if (!rproc_dbg)

			pr_err("can't create debugfs dir\n");

	}

}



void __exit rproc_exit_debugfs(void)