Commit 698b1010 authored by Hawking Zhang's avatar Hawking Zhang Committed by Alex Deucher
Browse files

drm/amdgpu: switch to cached fw flags for sram ecc cap 



Check cached firmware_flags to determine whether
sram ecc is supported or not.

Signed-off-by: default avatarHawking Zhang <Hawking.Zhang@amd.com>
Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Reviewed-by: default avatarJohn Clements <john.clements@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 58ff791a

drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c

+7 −21
Original line number Diff line number Diff line
@@ -437,33 +437,19 @@ bool amdgpu_atomfirmware_mem_ecc_supported(struct amdgpu_device *adev) 
}



/*

 * Helper function to query sram ecc capablity

 *

 * @adev: amdgpu_device pointer

 *

 * Return true if vbios supports sram ecc or false if not

 */

bool amdgpu_atomfirmware_sram_ecc_supported(struct amdgpu_device *adev)

{

	struct amdgpu_mode_info *mode_info = &adev->mode_info;

	int index;

	u16 data_offset, size;

	union firmware_info *firmware_info;

	u8 frev, crev;

	bool sram_ecc_supported = false;



	index = get_index_into_master_table(atom_master_list_of_data_tables_v2_1,

			firmwareinfo);

	u32 fw_cap;



	if (amdgpu_atom_parse_data_header(adev->mode_info.atom_context,

				index, &size, &frev, &crev, &data_offset)) {

		/* support firmware_info 3.1 + */

		if ((frev == 3 && crev >=1) || (frev > 3)) {

			firmware_info = (union firmware_info *)

				(mode_info->atom_context->bios + data_offset);

			sram_ecc_supported =

				(le32_to_cpu(firmware_info->v31.firmware_capability) &

				 ATOM_FIRMWARE_CAP_SRAM_ECC) ? true : false;

		}

	}

	fw_cap = adev->mode_info.firmware_flags;



	return sram_ecc_supported;

	return (fw_cap & ATOM_FIRMWARE_CAP_SRAM_ECC) ? true : false;

}



union smu_info {