Commit 698d8d87 authored by Jeff Layton's avatar Jeff Layton Committed by J. Bruce Fields
Browse files

nfsd: fix error handling in nfsd4_remove_clid_dir 



If the credential save fails, then we'll leak our mnt_want_write_file
reference.

Signed-off-by: default avatarJeff Layton <jlayton@redhat.com>
Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
parent 292a4171

fs/nfsd/nfs4recover.c

+2 −1
Original line number Diff line number Diff line
@@ -301,12 +301,13 @@ nfsd4_remove_clid_dir(struct nfs4_client *clp) 


	status = nfs4_save_creds(&original_cred);

	if (status < 0)

		goto out;

		goto out_drop_write;



	status = nfsd4_unlink_clid_dir(clp->cl_recdir, HEXDIR_LEN-1);

	nfs4_reset_creds(original_cred);

	if (status == 0)

		vfs_fsync(rec_file, 0);

out_drop_write:

	mnt_drop_write_file(rec_file);

out:

	if (status)