Commit 69d0fc22 authored by Giovanni Cabiddu's avatar Giovanni Cabiddu Committed by Herbert Xu
Browse files

crypto: qat - change return value in adf_cfg_add_key_value_param() 



If the parameter type provided to adf_cfg_add_key_value_param()
is invalid, return -EINVAL instead of -1 that is treated as -EPERM and
may confuse.

Suggested-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarGiovanni Cabiddu <giovanni.cabiddu@intel.com>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 83ab8c4b

drivers/crypto/qat/qat_common/adf_cfg.c

+1 −1
Original line number Diff line number Diff line
@@ -243,7 +243,7 @@ int adf_cfg_add_key_value_param(struct adf_accel_dev *accel_dev, 
	} else {

		dev_err(&GET_DEV(accel_dev), "Unknown type given.\n");

		kfree(key_val);

		return -1;

		return -EINVAL;

	}

	key_val->type = type;

	down_write(&cfg->lock);