Commit 69f90b70 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Jens Axboe
Browse files

block: unhash the inode earlier in delete_partition 



Move the call to remove_inode_hash to the beginning of delete_partition,
as we want to prevent opening a block_device that is about to be removed
ASAP.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Acked-by: default avatarDave Chinner <dchinner@redhat.com>
Reviewed-by: default avatarDave Chinner <dchinner@redhat.com>
Link: https://lore.kernel.org/r/20230601094459.1350643-7-hch@lst.de


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent a4f75764

block/partitions/core.c

+6 −6
Original line number Diff line number Diff line
@@ -267,6 +267,12 @@ static void delete_partition(struct block_device *part) 
{

	lockdep_assert_held(&part->bd_disk->open_mutex);



	/*

	 * Remove the block device from the inode hash, so that it cannot be

	 * looked up any more even when openers still hold references.

	 */

	remove_inode_hash(part->bd_inode);



	fsync_bdev(part);

	__invalidate_device(part, true);
@@ -274,12 +280,6 @@ static void delete_partition(struct block_device *part) 
	kobject_put(part->bd_holder_dir);

	device_del(&part->bd_device);



	/*

	 * Remove the block device from the inode hash, so that it cannot be

	 * looked up any more even when openers still hold references.

	 */

	remove_inode_hash(part->bd_inode);



	put_device(&part->bd_device);

}