Unverified Commit 6ad864ed authored by Viorel Suman's avatar Viorel Suman Committed by Mark Brown
Browse files

ASoC: fsl_spdif: use snd_ctl_boolean_mono_info 



Remove redundant code and use snd_ctl_boolean_mono_info
instead.

Signed-off-by: default avatarViorel Suman <viorel.suman@nxp.com>
Signed-off-by: default avatarShengjiu Wang <shengjiu.wang@nxp.com>
Link: https://lore.kernel.org/r/1615887736-31217-1-git-send-email-shengjiu.wang@nxp.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 54d796b8

sound/soc/fsl/fsl_spdif.c

+3 −27
Original line number Diff line number Diff line
@@ -801,18 +801,6 @@ static int fsl_spdif_qget(struct snd_kcontrol *kcontrol, 
	return ret;

}



/* Valid bit information */

static int fsl_spdif_vbit_info(struct snd_kcontrol *kcontrol,

				struct snd_ctl_elem_info *uinfo)

{

	uinfo->type = SNDRV_CTL_ELEM_TYPE_BOOLEAN;

	uinfo->count = 1;

	uinfo->value.integer.min = 0;

	uinfo->value.integer.max = 1;



	return 0;

}



/* Get valid good bit from interrupt status register */

static int fsl_spdif_rx_vbit_get(struct snd_kcontrol *kcontrol,

				 struct snd_ctl_elem_value *ucontrol)
@@ -925,18 +913,6 @@ static int fsl_spdif_rxrate_get(struct snd_kcontrol *kcontrol, 
	return 0;

}



/* User bit sync mode info */

static int fsl_spdif_usync_info(struct snd_kcontrol *kcontrol,

				struct snd_ctl_elem_info *uinfo)

{

	uinfo->type = SNDRV_CTL_ELEM_TYPE_BOOLEAN;

	uinfo->count = 1;

	uinfo->value.integer.min = 0;

	uinfo->value.integer.max = 1;



	return 0;

}



/*

 * User bit sync mode:

 * 1 CD User channel subcode
@@ -1018,7 +994,7 @@ static struct snd_kcontrol_new fsl_spdif_ctrls[] = { 
		.name = "IEC958 RX V-Bit Errors",

		.access = SNDRV_CTL_ELEM_ACCESS_READ |

			SNDRV_CTL_ELEM_ACCESS_VOLATILE,

		.info = fsl_spdif_vbit_info,

		.info = snd_ctl_boolean_mono_info,

		.get = fsl_spdif_rx_vbit_get,

	},

	{
@@ -1027,7 +1003,7 @@ static struct snd_kcontrol_new fsl_spdif_ctrls[] = { 
		.access = SNDRV_CTL_ELEM_ACCESS_READ |

			SNDRV_CTL_ELEM_ACCESS_WRITE |

			SNDRV_CTL_ELEM_ACCESS_VOLATILE,

		.info = fsl_spdif_vbit_info,

		.info = snd_ctl_boolean_mono_info,

		.get = fsl_spdif_tx_vbit_get,

		.put = fsl_spdif_tx_vbit_put,

	},
@@ -1047,7 +1023,7 @@ static struct snd_kcontrol_new fsl_spdif_ctrls[] = { 
		.access = SNDRV_CTL_ELEM_ACCESS_READ |

			SNDRV_CTL_ELEM_ACCESS_WRITE |

			SNDRV_CTL_ELEM_ACCESS_VOLATILE,

		.info = fsl_spdif_usync_info,

		.info = snd_ctl_boolean_mono_info,

		.get = fsl_spdif_usync_get,

		.put = fsl_spdif_usync_put,

	},