Skip to content
Commit 6b136a24 authored by Eryu Guan's avatar Eryu Guan Committed by Jens Axboe
Browse files

blk-mq-debugfs: don't allow write on attributes with seq_operations set



Attributes that only implement .seq_ops are read-only, any write to
them should be rejected. But currently kernel would crash when
writing to such debugfs entries, e.g.

chmod +w /sys/kernel/debug/block/<dev>/requeue_list
echo 0 > /sys/kernel/debug/block/<dev>/requeue_list
chmod -w /sys/kernel/debug/block/<dev>/requeue_list

Fix it by returning -EPERM in blk_mq_debugfs_write() when writing to
such attributes.

Cc: Ming Lei <ming.lei@redhat.com>
Signed-off-by: default avatarEryu Guan <eguan@redhat.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 20d59023
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment