Commit 6b3703f4 authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman
Browse files

staging: comedi: comedi_fops: remove BUG_ON() in comedi_cleanup() 



The BUG_ON() checks in this function are not necessary.

comedi_cleanup_board_minors() clears all the entries in the
comedi_board_minor_table array and will call comedi_device_cleanup()
for all attached devices. comedi_device_cleanup() will then
clear the entries in the comedi_subdevice_minor_table array with
comedi_free_subdevice_minor().

Remove the BUG_ON(), drivers should not crash the kernel.

Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: default avatarIan Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0bb6419c

drivers/staging/comedi/comedi_fops.c

+0 −7
Original line number Diff line number Diff line
@@ -2930,14 +2930,7 @@ module_init(comedi_init); 


static void __exit comedi_cleanup(void)

{

	int i;



	comedi_cleanup_board_minors();

	for (i = 0; i < COMEDI_NUM_BOARD_MINORS; ++i)

		BUG_ON(comedi_board_minor_table[i]);

	for (i = 0; i < COMEDI_NUM_SUBDEVICE_MINORS; ++i)

		BUG_ON(comedi_subdevice_minor_table[i]);



	class_destroy(comedi_class);

	cdev_del(&comedi_cdev);

	unregister_chrdev_region(MKDEV(COMEDI_MAJOR, 0), COMEDI_NUM_MINORS);