Commit 6c73d320 authored by Jakob Koschel's avatar Jakob Koschel Committed by Greg Kroah-Hartman
Browse files

staging: greybus: codecs: use dedicated list iterator variable 

In preparation to limit the scope of the list iterator to the list
traversal loop, use a dedicated pointer to point to the found element [1].

Link: https://lore.kernel.org/all/YhdfEIwI4EdtHdym@kroah.com/


Reviewed-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarVaibhav Agarwal <vaibhav.sr@gmail.com>
Reviewed-by: default avatarMark Greer <mgreer@animalcreek.com>
Signed-off-by: default avatarJakob Koschel <jakobkoschel@gmail.com>
Link: https://lore.kernel.org/r/20220321123712.3068778-1-jakobkoschel@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 77714e53

drivers/staging/greybus/audio_codec.c

+12 −8
Original line number Diff line number Diff line
@@ -497,7 +497,7 @@ static int gbcodec_prepare(struct snd_pcm_substream *substream, 
			   struct snd_soc_dai *dai)

{

	int ret;

	struct gbaudio_module_info *module;

	struct gbaudio_module_info *module = NULL, *iter;

	struct gbaudio_data_connection *data;

	struct gb_bundle *bundle;

	struct gbaudio_codec_info *codec = dev_get_drvdata(dai->dev);
@@ -511,12 +511,14 @@ static int gbcodec_prepare(struct snd_pcm_substream *substream, 
		return -ENODEV;

	}



	list_for_each_entry(module, &codec->module_list, list) {

	list_for_each_entry(iter, &codec->module_list, list) {

		/* find the dai */

		data = find_data(module, dai->id);

		if (data)

		data = find_data(iter, dai->id);

		if (data) {

			module = iter;

			break;

		}

	}

	if (!data) {

		dev_err(dai->dev, "DATA connection missing\n");

		mutex_unlock(&codec->lock);
@@ -563,7 +565,7 @@ static int gbcodec_mute_stream(struct snd_soc_dai *dai, int mute, int stream) 
{

	int ret;

	struct gbaudio_data_connection *data;

	struct gbaudio_module_info *module;

	struct gbaudio_module_info *module = NULL, *iter;

	struct gb_bundle *bundle;

	struct gbaudio_codec_info *codec = dev_get_drvdata(dai->dev);

	struct gbaudio_stream_params *params;
@@ -592,12 +594,14 @@ static int gbcodec_mute_stream(struct snd_soc_dai *dai, int mute, int stream) 
		return ret;

	}



	list_for_each_entry(module, &codec->module_list, list) {

	list_for_each_entry(iter, &codec->module_list, list) {

		/* find the dai */

		data = find_data(module, dai->id);

		if (data)

		data = find_data(iter, dai->id);

		if (data) {

			module = iter;

			break;

		}

	}

	if (!data) {

		dev_err(dai->dev, "%s:%s DATA connection missing\n",

			dai->name, module->name);