Commit 6ee0a22e authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Chanwoo Choi
Browse files

extcon: Use sysfs_emit() to instead of sprintf() 



Follow the advice of the Documentation/filesystems/sysfs.rst that
show() should only use sysfs_emit() or sysfs_emit_at() when formatting
the value to be returned to user space.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarChanwoo Choi <cw00.choi@samsung.com>
parent 6e4e8670

drivers/extcon/extcon.c

+9 −9
Original line number Diff line number Diff line
@@ -370,10 +370,10 @@ static ssize_t state_show(struct device *dev, struct device_attribute *attr, 
	struct extcon_dev *edev = dev_get_drvdata(dev);



	if (edev->max_supported == 0)

		return sprintf(buf, "%u\n", edev->state);

		return sysfs_emit(buf, "%u\n", edev->state);



	for (i = 0; i < edev->max_supported; i++) {

		count += sprintf(buf + count, "%s=%d\n",

		count += sysfs_emit_at(buf, count, "%s=%d\n",

				       extcon_info[edev->supported_cable[i]].name,

				       !!(edev->state & BIT(i)));

	}
@@ -387,7 +387,7 @@ static ssize_t name_show(struct device *dev, struct device_attribute *attr, 
{

	struct extcon_dev *edev = dev_get_drvdata(dev);



	return sprintf(buf, "%s\n", edev->name);

	return sysfs_emit(buf, "%s\n", edev->name);

}

static DEVICE_ATTR_RO(name);
@@ -398,7 +398,7 @@ static ssize_t cable_name_show(struct device *dev, 
						  attr_name);

	int i = cable->cable_index;



	return sprintf(buf, "%s\n",

	return sysfs_emit(buf, "%s\n",

			  extcon_info[cable->edev->supported_cable[i]].name);

}
@@ -410,7 +410,7 @@ static ssize_t cable_state_show(struct device *dev, 


	int i = cable->cable_index;



	return sprintf(buf, "%d\n",

	return sysfs_emit(buf, "%d\n",

			  extcon_get_state(cable->edev, cable->edev->supported_cable[i]));

}