Commit 6f3cdf2b authored by Yang Yingliang's avatar Yang Yingliang Committed by Greg Kroah-Hartman
Browse files

serial: pic32: fix missing clk_disable_unprepare() on error in pic32_uart_startup() 



Fix the missing clk_disable_unprepare() before return
from pic32_uart_startup() in the error handling case.

Fixes: 157b9394 ("serial: pic32_uart: Add PIC32 UART driver")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Reviewed-by: default avatarJiri Slaby <jirislaby@kernel.org>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20220525021204.2407631-1-yangyingliang@huawei.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d93e612d

drivers/tty/serial/pic32_uart.c

+3 −1
Original line number Diff line number Diff line
@@ -503,7 +503,7 @@ static int pic32_uart_startup(struct uart_port *port) 
	if (!sport->irq_fault_name) {

		dev_err(port->dev, "%s: kasprintf err!", __func__);

		ret = -ENOMEM;

		goto out_done;

		goto out_disable_clk;

	}

	irq_set_status_flags(sport->irq_fault, IRQ_NOAUTOEN);

	ret = request_irq(sport->irq_fault, pic32_uart_fault_interrupt,
@@ -579,6 +579,8 @@ static int pic32_uart_startup(struct uart_port *port) 
out_f:

	free_irq(sport->irq_fault, port);

	kfree(sport->irq_fault_name);

out_disable_clk:

	clk_disable_unprepare(sport->clk);

out_done:

	return ret;

}