Commit 7030a96b authored Mar 23, 2021 by Colin Ian King Committed by Mauro Carvalho Chehab Apr 09, 2021

media: dvb-frontends: Remove redundant error check on variable ret



An earlier commit removed a call to lgdt3306a_spectral_inversion and
omitted to remove the error return check. The check on ret is now
redundant and can be removed.

Addresses-Coverity: ("Logically dead code")

Fixes: d4a3fa66 ("media: dvb-frontends: lgdt3306a.c: remove dead code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

parent a2e2c1b8

drivers/media/dvb-frontends/lgdt3306a.c

+0 −3

Original line number	Original line	Diff line number	Diff line
	@@ -1017,9 +1017,6 @@ static int lgdt3306a_set_parameters(struct dvb_frontend *fe)

	/* spectral_inversion defaults already set for VSB and QAM */		/* spectral_inversion defaults already set for VSB and QAM */

	if (lg_chkerr(ret))
	goto fail;

	ret = lgdt3306a_mpeg_mode(state, state->cfg->mpeg_mode);		ret = lgdt3306a_mpeg_mode(state, state->cfg->mpeg_mode);
	if (lg_chkerr(ret))		if (lg_chkerr(ret))
	goto fail;		goto fail;