Commit 717aeab4 authored by Jagdish Gediya's avatar Jagdish Gediya Committed by Andrew Morton
Browse files

mm: convert sysfs input to bool using kstrtobool() 

Sysfs input conversion to corrosponding bool value e.g.  "false" or "0" to
false, "true" or "1" to true are currently handled through strncmp at
multiple places.  Use kstrtobool() to convert sysfs input to bool value.

[akpm@linux-foundation.org: propagate kstrtobool() return value, per Andy]
Link: https://lkml.kernel.org/r/20220426180203.70782-2-jvgediya@linux.ibm.com


Signed-off-by: default avatarJagdish Gediya <jvgediya@linux.ibm.com>
Reviewed-by: default avatarMatthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Dave Hansen <dave.hansen@intel.com>
Cc: "Huang, Ying" <ying.huang@intel.com>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Petr Mladek <pmladek@suse.com>
Cc: Richard Fitzgerald <rf@opensource.cirrus.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 0d6ea3ac

mm/migrate.c

+5 −6
Original line number Diff line number Diff line
@@ -2523,12 +2523,11 @@ static ssize_t numa_demotion_enabled_store(struct kobject *kobj, 
					   struct kobj_attribute *attr,

					   const char *buf, size_t count)

{

	if (!strncmp(buf, "true", 4) || !strncmp(buf, "1", 1))

		numa_demotion_enabled = true;

	else if (!strncmp(buf, "false", 5) || !strncmp(buf, "0", 1))

		numa_demotion_enabled = false;

	else

		return -EINVAL;

	ssize_t ret;



	ret = kstrtobool(buf, &numa_demotion_enabled);

	if (ret)

		return ret;



	return count;

}

mm/swap_state.c

+5 −6
Original line number Diff line number Diff line
@@ -874,12 +874,11 @@ static ssize_t vma_ra_enabled_store(struct kobject *kobj, 
				      struct kobj_attribute *attr,

				      const char *buf, size_t count)

{

	if (!strncmp(buf, "true", 4) || !strncmp(buf, "1", 1))

		enable_vma_readahead = true;

	else if (!strncmp(buf, "false", 5) || !strncmp(buf, "0", 1))

		enable_vma_readahead = false;

	else

		return -EINVAL;

	ssize_t ret;



	ret = kstrtobool(buf, &enable_vma_readahead);

	if (ret)

		return ret;



	return count;

}