Commit 71839eac authored by Fabio Aiuto's avatar Fabio Aiuto Committed by Greg Kroah-Hartman
Browse files

staging: rtl8723bs: fix comparison to null 



fix following post-commit hook checkpatch issues:

CHECK: Comparison to NULL could be written "!pmlmepriv->wps_probe_req_ie"
348: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:1319:
+			if (pmlmepriv->wps_probe_req_ie == NULL)

CHECK: Comparison to NULL could be written "!dvobj"
459: FILE: drivers/staging/rtl8723bs/os_dep/sdio_intf.c:184:
+	if (dvobj == NULL)

CHECK: Comparison to NULL could be written "!padapter"
470: FILE: drivers/staging/rtl8723bs/os_dep/sdio_intf.c:231:
+	if (padapter == NULL)

CHECK: Comparison to NULL could be written "!padapter"
481: FILE: drivers/staging/rtl8723bs/os_dep/sdio_intf.c:240:
+	if (padapter == NULL)

CHECK: Comparison to NULL could be written "!padapter"
492: FILE: drivers/staging/rtl8723bs/os_dep/sdio_intf.c:256:
+	if (padapter == NULL)

Signed-off-by: default avatarFabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/2c7557a465aeda7fb6989df30c6250f9ec56ebe1.1618064274.git.fabioaiuto83@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 04c35396

drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c

+1 −1
Original line number Diff line number Diff line
@@ -1316,7 +1316,7 @@ static int rtw_cfg80211_set_probe_req_wpsp2pie(struct adapter *padapter, char *b 
			}



			pmlmepriv->wps_probe_req_ie = rtw_malloc(wps_ielen);

			if (pmlmepriv->wps_probe_req_ie == NULL)

			if (!pmlmepriv->wps_probe_req_ie)

				return -EINVAL;



			memcpy(pmlmepriv->wps_probe_req_ie, wps_ie, wps_ielen);

drivers/staging/rtl8723bs/os_dep/sdio_intf.c

+4 −4
Original line number Diff line number Diff line
@@ -181,7 +181,7 @@ static struct dvobj_priv *sdio_dvobj_init(struct sdio_func *func) 
	struct sdio_data *psdio;



	dvobj = devobj_init();

	if (dvobj == NULL)

	if (!dvobj)

		goto exit;



	sdio_set_drvdata(func, dvobj);
@@ -228,7 +228,7 @@ void rtw_set_hal_ops(struct adapter *padapter) 


static void sd_intf_start(struct adapter *padapter)

{

	if (padapter == NULL)

	if (!padapter)

		return;



	/*  hal dep */
@@ -237,7 +237,7 @@ static void sd_intf_start(struct adapter *padapter) 


static void sd_intf_stop(struct adapter *padapter)

{

	if (padapter == NULL)

	if (!padapter)

		return;



	/*  hal dep */
@@ -253,7 +253,7 @@ static struct adapter *rtw_sdio_if1_init(struct dvobj_priv *dvobj, const struct 
	struct sdio_data *psdio = &dvobj->intf_data;



	padapter = vzalloc(sizeof(*padapter));

	if (padapter == NULL)

	if (!padapter)

		goto exit;



	padapter->dvobj = dvobj;