Commit 721d7f49 authored by Martin Kaiser's avatar Martin Kaiser Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: make on_action_public static void 



The on_action_public function is called only by OnAction. This function
also lives in rtw_mlme_ext.c and does not check the return value from
on_action_public.

We can make on_action_public a static void function.

The ret variable is no longer needed if we don't return a value. It can
be removed.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Signed-off-by: default avatarMartin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20221030173326.1588647-4-martin@kaiser.cx


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5998e319

drivers/staging/r8188eu/core/rtw_mlme_ext.c

+4 −8
Original line number Diff line number Diff line
@@ -3813,30 +3813,26 @@ static unsigned int on_action_public_default(struct recv_frame *precv_frame) 
	return ret;

}



unsigned int on_action_public(struct adapter *padapter, struct recv_frame *precv_frame)

static void on_action_public(struct adapter *padapter, struct recv_frame *precv_frame)

{

	struct ieee80211_mgmt *mgmt = (struct ieee80211_mgmt *)precv_frame->rx_data;

	unsigned int ret = _FAIL;

	u8 *pframe = precv_frame->rx_data;

	u8 *frame_body = pframe + sizeof(struct ieee80211_hdr_3addr);

	u8 action;



	/* check RA matches or not */

	if (memcmp(myid(&padapter->eeprompriv), mgmt->da, ETH_ALEN))

		goto exit;

		return;



	action = frame_body[1];

	switch (action) {

	case ACT_PUBLIC_VENDOR:

		ret = on_action_public_vendor(precv_frame);

		on_action_public_vendor(precv_frame);

		break;

	default:

		ret = on_action_public_default(precv_frame);

		on_action_public_default(precv_frame);

		break;

	}



exit:

	return ret;

}



unsigned int OnAction_p2p(struct adapter *padapter, struct recv_frame *precv_frame)

drivers/staging/r8188eu/include/rtw_mlme_ext.h

+0 −2
Original line number Diff line number Diff line
@@ -538,8 +538,6 @@ void start_create_ibss(struct adapter *padapter); 


unsigned int OnAction_back(struct adapter *padapter,

			   struct recv_frame *precv_frame);

unsigned int on_action_public(struct adapter *padapter,

			      struct recv_frame *precv_frame);

unsigned int OnAction_p2p(struct adapter *padapter,

			  struct recv_frame *precv_frame);