Commit 72d70bf7 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Greg Kroah-Hartman
Browse files

usb: typec: wcove: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart from
emitting a warning) and this typically results in resource leaks. To improve
here there is a quest to make the remove callback return void. In the first
step of this quest all drivers are converted to .remove_new() which already
returns void. Eventually after all drivers are converted, .remove_new() is
renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: default avatarGuenter Roeck <linux@roeck-us.net>
Acked-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20230517230239.187727-96-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 529ae3fe

drivers/usb/typec/tcpm/wcove.c

+2 −4
Original line number Diff line number Diff line
@@ -671,7 +671,7 @@ static int wcove_typec_probe(struct platform_device *pdev) 
	return 0;

}



static int wcove_typec_remove(struct platform_device *pdev)

static void wcove_typec_remove(struct platform_device *pdev)

{

	struct wcove_typec *wcove = platform_get_drvdata(pdev);

	unsigned int val;
@@ -684,8 +684,6 @@ static int wcove_typec_remove(struct platform_device *pdev) 


	tcpm_unregister_port(wcove->tcpm);

	fwnode_remove_software_node(wcove->tcpc.fwnode);



	return 0;

}



static struct platform_driver wcove_typec_driver = {
@@ -693,7 +691,7 @@ static struct platform_driver wcove_typec_driver = { 
		.name		= "bxt_wcove_usbc",

	},

	.probe			= wcove_typec_probe,

	.remove			= wcove_typec_remove,

	.remove_new		= wcove_typec_remove,

};



module_platform_driver(wcove_typec_driver);