Commit 74b681bd authored by Benjamin Mugnier's avatar Benjamin Mugnier Committed by Mauro Carvalho Chehab
Browse files

media: i2c: st-vgxy61: Fix regulator counter underflow 



Previously regulators were enabled on probe and never again.
However, as regulators are disabled on power off. After a second power off
the regulator counter will underflow. Plus regulators are not required
for probing the sensor, but for streaming.
Fix this by enabling regulators on power on to balance regulator counter
properly.

Signed-off-by: default avatarBenjamin Mugnier <benjamin.mugnier@foss.st.com>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent e6452894

drivers/media/i2c/st-vgxy61.c

+7 −7
Original line number Diff line number Diff line
@@ -1711,6 +1711,13 @@ static int vgxy61_power_on(struct device *dev) 
	struct vgxy61_dev *sensor = to_vgxy61_dev(sd);

	int ret;



	ret = regulator_bulk_enable(ARRAY_SIZE(vgxy61_supply_name),

				    sensor->supplies);

	if (ret) {

		dev_err(&client->dev, "failed to enable regulators %d\n", ret);

		return ret;

	}



	ret = clk_prepare_enable(sensor->xclk);

	if (ret) {

		dev_err(&client->dev, "failed to enable clock %d\n", ret);
@@ -1847,13 +1854,6 @@ static int vgxy61_probe(struct i2c_client *client) 
		return ret;

	}



	ret = regulator_bulk_enable(ARRAY_SIZE(vgxy61_supply_name),

				    sensor->supplies);

	if (ret) {

		dev_err(&client->dev, "failed to enable regulators %d\n", ret);

		return ret;

	}



	ret = vgxy61_power_on(dev);

	if (ret)

		return ret;