Commit 76dd7068 authored by Robin Murphy's avatar Robin Murphy Committed by Rob Herring
Browse files

of: address: Report of_dma_get_range() errors meaningfully 



If we failed to translate a DMA address, at least show the offending
address rather than the uninitialised contents of the destination
argument.

Signed-off-by: default avatarRobin Murphy <robin.murphy@arm.com>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Tested-by: default avatarNicolas Saenz Julienne <nsaenzjulienne@suse.de>
Reviewed-by: default avatarNicolas Saenz Julienne <nsaenzjulienne@suse.de>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarRob Herring <robh@kernel.org>
parent 6e6faf63

drivers/of/address.c

+2 −2
Original line number Diff line number Diff line
@@ -955,8 +955,8 @@ int of_dma_get_range(struct device_node *np, u64 *dma_addr, u64 *paddr, u64 *siz 
	dmaaddr = of_read_number(ranges, naddr);

	*paddr = of_translate_dma_address(np, ranges);

	if (*paddr == OF_BAD_ADDR) {

		pr_err("translation of DMA address(%pad) to CPU address failed node(%pOF)\n",

		       dma_addr, np);

		pr_err("translation of DMA address(%llx) to CPU address failed node(%pOF)\n",

		       dmaaddr, np);

		ret = -EINVAL;

		goto out;

	}