Commit 771075e1 authored by Matthew Wilcox (Oracle)'s avatar Matthew Wilcox (Oracle)
Browse files

ufs: Remove checks for PageError 



If read_mapping_page() encounters an error, it returns an errno, not
a page with PageError set, or a page that is not Uptodate, so this is
dead code.

Signed-off-by: default avatarMatthew Wilcox (Oracle) <willy@infradead.org>
parent b0c971e7

fs/ufs/dir.c

+1 −1
Original line number Diff line number Diff line
@@ -193,7 +193,7 @@ static struct page *ufs_get_page(struct inode *dir, unsigned long n) 
	if (!IS_ERR(page)) {

		kmap(page);

		if (unlikely(!PageChecked(page))) {

			if (PageError(page) || !ufs_check_page(page))

			if (!ufs_check_page(page))

				goto fail;

		}

	}

fs/ufs/util.c

+0 −11
Original line number Diff line number Diff line
@@ -264,17 +264,6 @@ struct page *ufs_get_locked_page(struct address_space *mapping, 
			put_page(page);

			return NULL;

		}



		if (!PageUptodate(page) || PageError(page)) {

			unlock_page(page);

			put_page(page);



			printk(KERN_ERR "ufs_change_blocknr: "

			       "can not read page: ino %lu, index: %lu\n",

			       inode->i_ino, index);



			return ERR_PTR(-EIO);

		}

	}

	if (!page_has_buffers(page))

		create_empty_buffers(page, 1 << inode->i_blkbits, 0);