Commit 7740bb88 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

net: vlan: update wrong comments 



vlan_insert_tag() and friends do not allocate a new skb.
However they might allocate a new skb->head.
Update their comments to better describe their behavior.

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6f5ca184

include/linux/if_vlan.h

+3 −3
Original line number Diff line number Diff line
@@ -408,7 +408,7 @@ static inline int __vlan_insert_tag(struct sk_buff *skb, 
 * @mac_len: MAC header length including outer vlan headers

 *

 * Inserts the VLAN tag into @skb as part of the payload at offset mac_len

 * Returns a VLAN tagged skb. If a new skb is created, @skb is freed.

 * Returns a VLAN tagged skb. This might change skb->head.

 *

 * Following the skb_unshare() example, in case of error, the calling function

 * doesn't have to worry about freeing the original skb.
@@ -437,7 +437,7 @@ static inline struct sk_buff *vlan_insert_inner_tag(struct sk_buff *skb, 
 * @vlan_tci: VLAN TCI to insert

 *

 * Inserts the VLAN tag into @skb as part of the payload

 * Returns a VLAN tagged skb. If a new skb is created, @skb is freed.

 * Returns a VLAN tagged skb. This might change skb->head.

 *

 * Following the skb_unshare() example, in case of error, the calling function

 * doesn't have to worry about freeing the original skb.
@@ -457,7 +457,7 @@ static inline struct sk_buff *vlan_insert_tag(struct sk_buff *skb, 
 * @vlan_tci: VLAN TCI to insert

 *

 * Inserts the VLAN tag into @skb as part of the payload

 * Returns a VLAN tagged skb. If a new skb is created, @skb is freed.

 * Returns a VLAN tagged skb. This might change skb->head.

 *

 * Following the skb_unshare() example, in case of error, the calling function

 * doesn't have to worry about freeing the original skb.