Commit 7797b4e0 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Takashi Iwai
Browse files

media/radio: Make radio_isa_common_remove() return void 



Instead of an unconditional return 0, return no value. One of the two
callers ignored the return value already before.

This simplifies the next patch.

Signed-off-by: default avatarUwe Kleine-König <uwe@kleine-koenig.org>
Reviewed-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Link: https://lore.kernel.org/r/20210122092449.426097-3-uwe@kleine-koenig.org


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent d2006bb7

drivers/media/radio/radio-isa.c

+5 −4
Original line number Diff line number Diff line
@@ -273,7 +273,7 @@ static int radio_isa_common_probe(struct radio_isa_card *isa, 
	return res;

}



static int radio_isa_common_remove(struct radio_isa_card *isa,

static void radio_isa_common_remove(struct radio_isa_card *isa,

				    unsigned region_size)

{

	const struct radio_isa_ops *ops = isa->drv->ops;
@@ -285,7 +285,6 @@ static int radio_isa_common_remove(struct radio_isa_card *isa, 
	release_region(isa->io, region_size);

	v4l2_info(&isa->v4l2_dev, "Removed radio card %s\n", isa->drv->card);

	kfree(isa);

	return 0;

}



int radio_isa_probe(struct device *pdev, unsigned int dev)
@@ -342,7 +341,9 @@ int radio_isa_remove(struct device *pdev, unsigned int dev) 
{

	struct radio_isa_card *isa = dev_get_drvdata(pdev);



	return radio_isa_common_remove(isa, isa->drv->region_size);

	radio_isa_common_remove(isa, isa->drv->region_size);



	return 0;

}

EXPORT_SYMBOL_GPL(radio_isa_remove);