Commit 789e5ebc authored by Miquel Raynal's avatar Miquel Raynal Committed by Lee Jones
Browse files

iio: adc: ti_am335x_adc: Add a unit to the timeout delay 



The lack of unit in the macro name kind of tricked me when I was
troubleshooting an issue. Physical constants should always get a unit.

Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Acked-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20211015081506.933180-44-miquel.raynal@bootlin.com
parent b61a9d32

drivers/iio/adc/ti_am335x_adc.c

+2 −2
Original line number Diff line number Diff line
@@ -101,7 +101,7 @@ static int tiadc_wait_idle(struct tiadc_device *adc_dev) 


	return readl_poll_timeout(adc_dev->mfd_tscadc->tscadc_base + REG_ADCFSM,

				  val, !(val & SEQ_STATUS), 10,

				  IDLE_TIMEOUT * 1000 * adc_dev->channels);

				  IDLE_TIMEOUT_MS * 1000 * adc_dev->channels);

}



static void tiadc_step_config(struct iio_dev *indio_dev)
@@ -461,7 +461,7 @@ static int tiadc_read_raw(struct iio_dev *indio_dev, 
	am335x_tsc_se_set_once(adc_dev->mfd_tscadc, step_en);



	/* Wait for Fifo threshold interrupt */

	timeout = jiffies + msecs_to_jiffies(IDLE_TIMEOUT * adc_dev->channels);

	timeout = jiffies + msecs_to_jiffies(IDLE_TIMEOUT_MS * adc_dev->channels);

	while (1) {

		fifo1count = tiadc_readl(adc_dev, REG_FIFO1CNT);

		if (fifo1count)

include/linux/mfd/ti_am335x_tscadc.h

+1 −1
Original line number Diff line number Diff line
@@ -141,7 +141,7 @@ 
 *

 * max processing time: 266431 * 308ns = 83ms(approx)

 */

#define IDLE_TIMEOUT		83 /* milliseconds */

#define IDLE_TIMEOUT_MS		83 /* milliseconds */



#define TSCADC_CELLS		2