Commit 79053469 authored by Haowen Bai's avatar Haowen Bai Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: Drop redundant memset overwritten by memcpy 



The region set by the call to memset is immediately overwritten by the
subsequent call to memcpy. So we drop redundant memset.

Signed-off-by: default avatarHaowen Bai <baihaowen@meizu.com>
Link: https://lore.kernel.org/r/1654084164-10869-1-git-send-email-baihaowen@meizu.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e8ab3828

drivers/staging/r8188eu/core/rtw_ioctl_set.c

+0 −1
Original line number Diff line number Diff line
@@ -71,7 +71,6 @@ u8 rtw_do_join(struct adapter *padapter) 


				pibss = padapter->registrypriv.dev_network.MacAddress;



				memset(&pdev_network->Ssid, 0, sizeof(struct ndis_802_11_ssid));

				memcpy(&pdev_network->Ssid, &pmlmepriv->assoc_ssid, sizeof(struct ndis_802_11_ssid));



				rtw_update_registrypriv_dev_network(padapter);

drivers/staging/r8188eu/core/rtw_mlme.c

+0 −2
Original line number Diff line number Diff line
@@ -676,7 +676,6 @@ void rtw_surveydone_event_callback(struct adapter *adapter, u8 *pbuf) 


					_clr_fwstate_(pmlmepriv, _FW_UNDER_SURVEY);



					memset(&pdev_network->Ssid, 0, sizeof(struct ndis_802_11_ssid));

					memcpy(&pdev_network->Ssid, &pmlmepriv->assoc_ssid, sizeof(struct ndis_802_11_ssid));



					rtw_update_registrypriv_dev_network(adapter);
@@ -1253,7 +1252,6 @@ void rtw_stadel_event_callback(struct adapter *adapter, u8 *pbuf) 


			memcpy(pdev_network, &tgt_network->network, get_wlan_bssid_ex_sz(&tgt_network->network));



			memset(&pdev_network->Ssid, 0, sizeof(struct ndis_802_11_ssid));

			memcpy(&pdev_network->Ssid, &pmlmepriv->assoc_ssid, sizeof(struct ndis_802_11_ssid));



			rtw_update_registrypriv_dev_network(adapter);