Commit 7da83f1b authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Alexandre Belloni
Browse files

rtc: da9063: Handle invalid IRQ from platform_get_irq_byname() 



platform_get_irq_byname() might return -errno which later would be
cast to an unsigned int and used in request_irq().

Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Tested-by: default avatarAdam Thomson <Adam.Thomson.Opensource@diasemi.com>
Link: https://lore.kernel.org/r/20191004150510.6278-1-krzk@kernel.org


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent cf79e7c3

drivers/rtc/rtc-da9063.c

+3 −0
Original line number Diff line number Diff line
@@ -483,6 +483,9 @@ static int da9063_rtc_probe(struct platform_device *pdev) 
		rtc->rtc_dev->uie_unsupported = 1;



	irq_alarm = platform_get_irq_byname(pdev, "ALARM");

	if (irq_alarm < 0)

		return irq_alarm;



	ret = devm_request_threaded_irq(&pdev->dev, irq_alarm, NULL,

					da9063_alarm_event,

					IRQF_TRIGGER_LOW | IRQF_ONESHOT,