Commit 7e00e0c4 authored by Michael Straube's avatar Michael Straube Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: correct error logic of rtl8188eu_init_recv_priv() 



Convert the function rtl8188eu_init_recv_priv() away from returning
_FAIL and _SUCCESS, which uses inverted error logic. Return 0 for
success and negative values for failure instead.

Signed-off-by: default avatarMichael Straube <straube.linux@gmail.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Link: https://lore.kernel.org/r/20230205080559.8319-2-straube.linux@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2f36e789

drivers/staging/r8188eu/core/rtw_recv.c

+8 −9
Original line number Diff line number Diff line
@@ -38,7 +38,7 @@ void _rtw_init_sta_recv_priv(struct sta_recv_priv *psta_recvpriv) 
static int rtl8188eu_init_recv_priv(struct adapter *padapter)

{

	struct recv_priv *precvpriv = &padapter->recvpriv;

	int i, res = _SUCCESS;

	int i, err = 0;

	struct recv_buf *precvbuf;



	tasklet_init(&precvpriv->recv_tasklet,
@@ -50,10 +50,8 @@ static int rtl8188eu_init_recv_priv(struct adapter *padapter) 


	precvpriv->pallocated_recv_buf = kzalloc(NR_RECVBUFF * sizeof(struct recv_buf) + 4,

						 GFP_KERNEL);

	if (!precvpriv->pallocated_recv_buf) {

		res = _FAIL;

		goto exit;

	}

	if (!precvpriv->pallocated_recv_buf)

		return -ENOMEM;



	precvpriv->precv_buf = (u8 *)ALIGN((size_t)(precvpriv->pallocated_recv_buf), 4);
@@ -64,7 +62,7 @@ static int rtl8188eu_init_recv_priv(struct adapter *padapter) 
		precvbuf->reuse = false;

		precvbuf->purb = usb_alloc_urb(0, GFP_KERNEL);

		if (!precvbuf->purb) {

			res = _FAIL;

			err = -ENOMEM;

			break;

		}

		precvbuf->adapter = padapter;
@@ -94,8 +92,8 @@ static int rtl8188eu_init_recv_priv(struct adapter *padapter) 
			pskb = NULL;

		}

	}

exit:

	return res;



	return err;

}



int _rtw_init_recv_priv(struct recv_priv *precvpriv, struct adapter *padapter)
@@ -141,7 +139,8 @@ int _rtw_init_recv_priv(struct recv_priv *precvpriv, struct adapter *padapter) 
	}

	precvpriv->rx_pending_cnt = 1;



	res = rtl8188eu_init_recv_priv(padapter);

	if (rtl8188eu_init_recv_priv(padapter))

		res = _FAIL;



	timer_setup(&precvpriv->signal_stat_timer, rtw_signal_stat_timer_hdl, 0);

	precvpriv->signal_stat_sampling_interval = 1000; /* ms */