Commit 800b8eec authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Rafael J. Wysocki
Browse files

platform/x86: int3472: Don't leak reference on error 



The for_each_acpi_consumer_dev() takes a reference to the iterator
and if we break a loop we must drop that reference. This usually
happens when error handling is involved. However it's not the case
for skl_int3472_fill_clk_pdata().

Don't leak reference on error by dropping it properly.

Fixes: 43cf3697 ("platform/x86: int3472: Support multiple clock consumers")
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 9388076b

drivers/platform/x86/intel/int3472/tps68470.c

+3 −3
Original line number Diff line number Diff line
@@ -128,15 +128,15 @@ skl_int3472_fill_clk_pdata(struct device *dev, struct tps68470_clk_platform_data 
	for_each_acpi_consumer_dev(adev, consumer) {

		sensor_name = devm_kasprintf(dev, GFP_KERNEL, I2C_DEV_NAME_FORMAT,

					     acpi_dev_name(consumer));

		if (!sensor_name)

		if (!sensor_name) {

			acpi_dev_put(consumer);

			return -ENOMEM;

		}



		(*clk_pdata)->consumers[i].consumer_dev_name = sensor_name;

		i++;

	}



	acpi_dev_put(consumer);



	return n_consumers;

}