Commit 80ae0369 authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

drm/todo: Convert drivers to generic fbdev emulation 



This replaces the original TODO item for drm_fb_helper_fbdev_setup()
and _teardown(), which are deprecated.

v2:
	* remove driver-specific comments
	* list some basic requirements
	* keep a TODO item on drm_fb_helper_init()

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: default avatarNoralf Trønnes <noralf@tronnes.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20191106124727.11641-2-tzimmermann@suse.de
parent 50ec5b56

Documentation/gpu/todo.rst

+7 −16
Original line number Original line Diff line number Diff line
@@ -171,21 +171,12 @@ Contact: Maintainer of the driver you plan to convert 




Level: Intermediate

Level: Intermediate





Convert drivers to use drm_fb_helper_fbdev_setup/teardown()

Convert drivers to use drm_fbdev_generic_setup()

-----------------------------------------------------------

------------------------------------------------





Most drivers can use drm_fb_helper_fbdev_setup() except maybe:

Most drivers can use drm_fbdev_generic_setup(). Driver have to implement



atomic modesetting and GEM vmap support. Current generic fbdev emulation

- amdgpu which has special logic to decide whether to call

expects the framebuffer in system memory (or system-like memory).

  drm_helper_disable_unused_functions()



- armada which isn't atomic and doesn't call

  drm_helper_disable_unused_functions()



- i915 which calls drm_fb_helper_initial_config() in a worker



Drivers that use drm_framebuffer_remove() to clean up the fbdev framebuffer can

probably use drm_fb_helper_fbdev_teardown().





Contact: Maintainer of the driver you plan to convert

Contact: Maintainer of the driver you plan to convert
@@ -328,8 +319,8 @@ drm_fb_helper tasks 
  these igt tests need to be fixed: kms_fbcon_fbt@psr and

  these igt tests need to be fixed: kms_fbcon_fbt@psr and

  kms_fbcon_fbt@psr-suspend.

  kms_fbcon_fbt@psr-suspend.





- The max connector argument for drm_fb_helper_init() and

- The max connector argument for drm_fb_helper_init() isn't used anymore and

  drm_fb_helper_fbdev_setup() isn't used anymore and can be removed.

  can be removed.





- The helper doesn't keep an array of connectors anymore so these can be

- The helper doesn't keep an array of connectors anymore so these can be

  removed: drm_fb_helper_single_add_all_connectors(),

  removed: drm_fb_helper_single_add_all_connectors(),