Commit 81e87888 authored by Peter Suti's avatar Peter Suti Committed by Greg Kroah-Hartman
Browse files

staging: fbtft: core: set smem_len before fb_deferred_io_init call 



The fbtft_framebuffer_alloc() calls fb_deferred_io_init() before
initializing info->fix.smem_len.  It is set to zero by the
framebuffer_alloc() function.  It will trigger a WARN_ON() at the
start of fb_deferred_io_init() and the function will not do anything.

Fixes: 856082f0 ("fbdev: defio: fix the pagelist corruption")
Signed-off-by: default avatarPeter Suti <peter.suti@streamunlimited.com>
Link: https://lore.kernel.org/r/20220727073550.1491126-1-peter.suti@streamunlimited.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2b5002e2

drivers/staging/fbtft/fbtft-core.c

+1 −1
Original line number Diff line number Diff line
@@ -654,7 +654,6 @@ struct fb_info *fbtft_framebuffer_alloc(struct fbtft_display *display, 
	fbdefio->delay =            HZ / fps;

	fbdefio->sort_pagereflist = true;

	fbdefio->deferred_io =      fbtft_deferred_io;

	fb_deferred_io_init(info);



	snprintf(info->fix.id, sizeof(info->fix.id), "%s", dev->driver->name);

	info->fix.type =           FB_TYPE_PACKED_PIXELS;
@@ -665,6 +664,7 @@ struct fb_info *fbtft_framebuffer_alloc(struct fbtft_display *display, 
	info->fix.line_length =    width * bpp / 8;

	info->fix.accel =          FB_ACCEL_NONE;

	info->fix.smem_len =       vmem_size;

	fb_deferred_io_init(info);



	info->var.rotate =         pdata->rotate;

	info->var.xres =           width;