Commit 81ff48dd authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Jason Gunthorpe
Browse files

RDMA/bnxt_re: Use bitmap_zalloc() when applicable 

Use 'bitmap_zalloc()' to simplify code, improve the semantic and avoid
some open-coded arithmetic in allocator arguments.

Also change the corresponding 'kfree()' into 'bitmap_free()' to keep
consistency.

Link: https://lore.kernel.org/r/5c029daf43b92fdc27926fe8a98084843437c498.1637872888.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent ecd68ef8

drivers/infiniband/hw/bnxt_re/qplib_rcfw.c

+2 −4
Original line number Original line Diff line number Diff line
@@ -555,7 +555,7 @@ int bnxt_qplib_init_rcfw(struct bnxt_qplib_rcfw *rcfw, 




void bnxt_qplib_free_rcfw_channel(struct bnxt_qplib_rcfw *rcfw)

void bnxt_qplib_free_rcfw_channel(struct bnxt_qplib_rcfw *rcfw)

{

{

	kfree(rcfw->cmdq.cmdq_bitmap);

	bitmap_free(rcfw->cmdq.cmdq_bitmap);

	kfree(rcfw->qp_tbl);

	kfree(rcfw->qp_tbl);

	kfree(rcfw->crsqe_tbl);

	kfree(rcfw->crsqe_tbl);

	bnxt_qplib_free_hwq(rcfw->res, &rcfw->cmdq.hwq);

	bnxt_qplib_free_hwq(rcfw->res, &rcfw->cmdq.hwq);
@@ -572,7 +572,6 @@ int bnxt_qplib_alloc_rcfw_channel(struct bnxt_qplib_res *res, 
	struct bnxt_qplib_sg_info sginfo = {};

	struct bnxt_qplib_sg_info sginfo = {};

	struct bnxt_qplib_cmdq_ctx *cmdq;

	struct bnxt_qplib_cmdq_ctx *cmdq;

	struct bnxt_qplib_creq_ctx *creq;

	struct bnxt_qplib_creq_ctx *creq;

	u32 bmap_size = 0;





	rcfw->pdev = res->pdev;

	rcfw->pdev = res->pdev;

	cmdq = &rcfw->cmdq;

	cmdq = &rcfw->cmdq;
@@ -613,8 +612,7 @@ int bnxt_qplib_alloc_rcfw_channel(struct bnxt_qplib_res *res, 
	if (!rcfw->crsqe_tbl)

	if (!rcfw->crsqe_tbl)

		goto fail;

		goto fail;





	bmap_size = BITS_TO_LONGS(rcfw->cmdq_depth) * sizeof(unsigned long);

	cmdq->cmdq_bitmap = bitmap_zalloc(rcfw->cmdq_depth, GFP_KERNEL);

	cmdq->cmdq_bitmap = kzalloc(bmap_size, GFP_KERNEL);

	if (!cmdq->cmdq_bitmap)

	if (!cmdq->cmdq_bitmap)

		goto fail;

		goto fail;