Commit 8213f6c9 authored by Jakub Kicinski's avatar Jakub Kicinski Committed by David S. Miller
Browse files

net: be2net: reject unsupported coalescing params 



Set ethtool_ops->supported_coalesce_params to let
the core reject unsupported coalescing parameters.

This driver did not previously reject unsupported parameters.

Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c7449b75

drivers/net/ethernet/emulex/benet/be_ethtool.c

+3 −0
Original line number Diff line number Diff line
@@ -1408,6 +1408,9 @@ static int be_set_priv_flags(struct net_device *netdev, u32 flags) 
}



const struct ethtool_ops be_ethtool_ops = {

	.supported_coalesce_params = ETHTOOL_COALESCE_USECS |

				     ETHTOOL_COALESCE_USE_ADAPTIVE |

				     ETHTOOL_COALESCE_USECS_LOW_HIGH,

	.get_drvinfo = be_get_drvinfo,

	.get_wol = be_get_wol,

	.set_wol = be_set_wol,

include/linux/ethtool.h

+3 −0
Original line number Diff line number Diff line
@@ -211,6 +211,9 @@ bool ethtool_convert_link_mode_to_legacy_u32(u32 *legacy_u32, 
	 ETHTOOL_COALESCE_TX_MAX_FRAMES_IRQ)

#define ETHTOOL_COALESCE_USE_ADAPTIVE					\

	(ETHTOOL_COALESCE_USE_ADAPTIVE_RX | ETHTOOL_COALESCE_USE_ADAPTIVE_TX)

#define ETHTOOL_COALESCE_USECS_LOW_HIGH					\

	(ETHTOOL_COALESCE_RX_USECS_LOW | ETHTOOL_COALESCE_TX_USECS_LOW | \

	 ETHTOOL_COALESCE_RX_USECS_HIGH | ETHTOOL_COALESCE_TX_USECS_HIGH)

#define ETHTOOL_COALESCE_PKT_RATE_RX_USECS				\

	(ETHTOOL_COALESCE_USE_ADAPTIVE_RX |				\

	 ETHTOOL_COALESCE_RX_USECS_LOW | ETHTOOL_COALESCE_RX_USECS_HIGH | \