Commit 826f55d5 authored by Mika Westerberg's avatar Mika Westerberg
Browse files

thunderbolt: Drop useless 'unidirectional' parameter from tb_switch_tmu_is_enabled() 



There is no point passing it as we already have a field for that. While
there clean up the kernel-doc of things that do not really belong to the
API documentation (these can be figured out from the spec itself).

No functional changes.

Signed-off-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
parent c437dcb1

drivers/thunderbolt/tb.c

+1 −1
Original line number Diff line number Diff line
@@ -362,7 +362,7 @@ static int tb_enable_tmu(struct tb_switch *sw) 
	int ret;



	/* If it is already enabled in correct mode, don't touch it */

	if (tb_switch_tmu_is_enabled(sw, sw->tmu.unidirectional_request))

	if (tb_switch_tmu_is_enabled(sw))

		return 0;



	ret = tb_switch_tmu_disable(sw);

drivers/thunderbolt/tb.h

+4 −6
Original line number Diff line number Diff line
@@ -995,16 +995,14 @@ void tb_switch_enable_tmu_1st_child(struct tb_switch *sw, 
/**

 * tb_switch_tmu_is_enabled() - Checks if the specified TMU mode is enabled

 * @sw: Router whose TMU mode to check

 * @unidirectional: If uni-directional (bi-directional otherwise)

 *

 * Return true if hardware TMU configuration matches the one passed in

 * as parameter. That is HiFi/Normal and either uni-directional or bi-directional.

 * Return true if hardware TMU configuration matches the requested

 * configuration.

 */

static inline bool tb_switch_tmu_is_enabled(const struct tb_switch *sw,

					    bool unidirectional)

static inline bool tb_switch_tmu_is_enabled(const struct tb_switch *sw)

{

	return sw->tmu.rate == sw->tmu.rate_request &&

	       sw->tmu.unidirectional == unidirectional;

	       sw->tmu.unidirectional == sw->tmu.unidirectional_request;

}



static inline const char *tb_switch_clx_name(enum tb_clx clx)

drivers/thunderbolt/tmu.c

+4 −7
Original line number Diff line number Diff line
@@ -639,12 +639,9 @@ static int tb_switch_tmu_change_mode(struct tb_switch *sw) 
 * tb_switch_tmu_enable() - Enable TMU on a router

 * @sw: Router whose TMU to enable

 *

 * Enables TMU of a router to be in uni-directional Normal/HiFi

 * or bi-directional HiFi mode. Calling tb_switch_tmu_configure() is required

 * before calling this function, to select the mode Normal/HiFi and

 * directionality (uni-directional/bi-directional).

 * In HiFi mode all tunneling should work. In Normal mode, DP tunneling can't

 * work. Uni-directional mode is required for CLx (Link Low-Power) to work.

 * Enables TMU of a router to be in uni-directional Normal/HiFi or

 * bi-directional HiFi mode. Calling tb_switch_tmu_configure() is

 * required before calling this function.

 */

int tb_switch_tmu_enable(struct tb_switch *sw)

{
@@ -662,7 +659,7 @@ int tb_switch_tmu_enable(struct tb_switch *sw) 
	if (!tb_switch_is_clx_supported(sw))

		return 0;



	if (tb_switch_tmu_is_enabled(sw, sw->tmu.unidirectional_request))

	if (tb_switch_tmu_is_enabled(sw))

		return 0;



	if (tb_switch_is_titan_ridge(sw) && unidirectional) {