Unverified Commit 82b21ca1 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Mark Brown
Browse files

ASoC: SOF: probes: Check ops before memory allocation 



We may check ops before spending resources on memory allocation.
While at it, utilize dev_get_platdata() helper.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: default avatarPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20221117103223.74425-1-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 6b6ab406

sound/soc/sof/sof-client-probes.c

+6 −8
Original line number Diff line number Diff line
@@ -399,23 +399,21 @@ static int sof_probes_client_probe(struct auxiliary_device *auxdev, 
	if (!sof_probes_enabled)

		return -ENXIO;



	if (!dev->platform_data) {

	ops = dev_get_platdata(dev);

	if (!ops) {

		dev_err(dev, "missing platform data\n");

		return -ENODEV;

	}



	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);

	if (!priv)

		return -ENOMEM;



	ops = dev->platform_data;



	if (!ops->startup || !ops->shutdown || !ops->set_params || !ops->trigger ||

	    !ops->pointer) {

		dev_err(dev, "missing platform callback(s)\n");

		return -ENODEV;

	}



	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);

	if (!priv)

		return -ENOMEM;



	priv->host_ops = ops;



	switch (sof_client_get_ipc_type(cdev)) {