Commit 8358014d authored by Chao Yu's avatar Chao Yu Committed by Jaegeuk Kim
Browse files

f2fs: avoid to check PG_error flag 



After below changes:
commit 14db0b3c ("fscrypt: stop using PG_error to track error status")
commit 98dc08ba ("fsverity: stop using PG_error to track error status")

There is no place in f2fs we will set PG_error flag in page, let's remove
other PG_error usage in f2fs, as a step towards freeing the PG_error flag
for other uses.

Cc: Eric Biggers <ebiggers@kernel.org>
Signed-off-by: default avatarChao Yu <chao@kernel.org>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent cec32b00

fs/f2fs/data.c

+0 −2
Original line number Diff line number Diff line
@@ -2701,7 +2701,6 @@ int f2fs_do_write_data_page(struct f2fs_io_info *fio) 
			goto out_writepage;



		set_page_writeback(page);

		ClearPageError(page);

		f2fs_put_dnode(&dn);

		if (fio->need_lock == LOCK_REQ)

			f2fs_unlock_op(fio->sbi);
@@ -2737,7 +2736,6 @@ int f2fs_do_write_data_page(struct f2fs_io_info *fio) 
		goto out_writepage;



	set_page_writeback(page);

	ClearPageError(page);



	if (fio->compr_blocks && fio->old_blkaddr == COMPRESS_ADDR)

		f2fs_i_compr_blocks_update(inode, fio->compr_blocks - 1, false);

fs/f2fs/gc.c

+0 −1
Original line number Diff line number Diff line
@@ -1364,7 +1364,6 @@ static int move_data_block(struct inode *inode, block_t bidx, 
		dec_page_count(fio.sbi, F2FS_DIRTY_META);



	set_page_writeback(fio.encrypted_page);

	ClearPageError(page);



	fio.op = REQ_OP_WRITE;

	fio.op_flags = REQ_SYNC;

fs/f2fs/inline.c

+0 −1
Original line number Diff line number Diff line
@@ -174,7 +174,6 @@ int f2fs_convert_inline_page(struct dnode_of_data *dn, struct page *page) 


	/* write data page to try to make data consistent */

	set_page_writeback(page);

	ClearPageError(page);

	fio.old_blkaddr = dn->data_blkaddr;

	set_inode_flag(dn->inode, FI_HOT_DATA);

	f2fs_outplace_write_data(dn, &fio);

fs/f2fs/node.c

+0 −3
Original line number Diff line number Diff line
@@ -1650,7 +1650,6 @@ static int __write_node_page(struct page *page, bool atomic, bool *submitted, 
	}



	set_page_writeback(page);

	ClearPageError(page);



	fio.old_blkaddr = ni.blk_addr;

	f2fs_do_write_node_page(nid, &fio);
@@ -2079,8 +2078,6 @@ int f2fs_wait_on_node_pages_writeback(struct f2fs_sb_info *sbi, 
		spin_unlock_irqrestore(&sbi->fsync_node_lock, flags);



		f2fs_wait_on_page_writeback(page, NODE, true, false);

		if (TestClearPageError(page))

			ret = -EIO;



		put_page(page);

fs/f2fs/segment.c

+0 −1
Original line number Diff line number Diff line
@@ -3422,7 +3422,6 @@ void f2fs_do_write_meta_page(struct f2fs_sb_info *sbi, struct page *page, 
		fio.op_flags &= ~REQ_META;



	set_page_writeback(page);

	ClearPageError(page);

	f2fs_submit_page_write(&fio);



	stat_inc_meta_count(sbi, page->index);