Unverified Commit 8419fd90 authored by Peter Ujfalusi's avatar Peter Ujfalusi Committed by Mark Brown
Browse files

ASoC: SOF: trace: Use sof_ipc_get_ops() in sof_fw_trace_init 



For the sake of safety use the sof_ipc_get_ops() to fetch the fw_tracing
ops to avoid cases when either sdev->ipc or sdev->ipc->ops might be NULL.

Signed-off-by: default avatarPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: default avatarRander Wang <rander.wang@intel.com>
Link: https://lore.kernel.org/r/20221221102328.9635-11-peter.ujfalusi@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 1cf79c34

sound/soc/sof/trace.c

+4 −2
Original line number Diff line number Diff line
@@ -6,14 +6,16 @@ 


int sof_fw_trace_init(struct snd_sof_dev *sdev)

{

	if (!sdev->ipc->ops->fw_tracing) {

	const struct sof_ipc_fw_tracing_ops *fw_tracing = sof_ipc_get_ops(sdev, fw_tracing);



	if (!fw_tracing) {

		dev_info(sdev->dev, "Firmware tracing is not available\n");

		sdev->fw_trace_is_supported = false;



		return 0;

	}



	return sdev->ipc->ops->fw_tracing->init(sdev);

	return fw_tracing->init(sdev);

}



void sof_fw_trace_free(struct snd_sof_dev *sdev)