Commit 8583d3b5 authored by John Garry's avatar John Garry Committed by Martin K. Petersen
Browse files

scsi: hisi_sas: remove init_id_frame_v1_hw() 



Function config_id_frame_v1_hw() is called twice for each PHY during
initialisation, which is unneeded.

So remove init_id_frame_v1_hw(), which only calls
config_id_frame_v1_hw().

We will keep the call to config_id_frame_v1_hw() in start_phy_v1_hw()
since it will be used for PHY reset functions.

Signed-off-by: default avatarJohn Garry <john.garry@huawei.com>
Signed-off-by: default avatarXiang Chen <chenxiang66@hisilicon.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 514f16e3

drivers/scsi/hisi_sas/hisi_sas_v1_hw.c

+0 −10
Original line number Diff line number Diff line
@@ -501,14 +501,6 @@ static void config_id_frame_v1_hw(struct hisi_hba *hisi_hba, int phy_no) 
			__swab32(identify_buffer[5]));

}



static void init_id_frame_v1_hw(struct hisi_hba *hisi_hba)

{

	int i;



	for (i = 0; i < hisi_hba->n_phy; i++)

		config_id_frame_v1_hw(hisi_hba, i);

}



static void setup_itct_v1_hw(struct hisi_hba *hisi_hba,

			     struct hisi_sas_device *sas_dev)

{
@@ -774,8 +766,6 @@ static int hw_init_v1_hw(struct hisi_hba *hisi_hba) 
	msleep(100);

	init_reg_v1_hw(hisi_hba);



	init_id_frame_v1_hw(hisi_hba);



	return 0;

}