Commit 86e18ac3 authored by Candice Li's avatar Candice Li Committed by Alex Deucher
Browse files

drm/amdgpu: Fix build warning for TA debugfs interface 



Remove the redundant codes to fix build warning
when CONFIG_DEBUG_FS is disabled.

Reported-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Signed-off-by: default avatarCandice Li <candice.li@amd.com>
Reviewed-by: default avatarYang Wang <kevinyang.wang@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 71199aa4

drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c

+14 −26
Original line number Diff line number Diff line
@@ -24,12 +24,7 @@ 
#include "amdgpu.h"

#include "amdgpu_psp_ta.h"



static const char *TA_IF_FS_NAME = "ta_if";



struct dentry *dir;

static struct dentry *ta_load_debugfs_dentry;

static struct dentry *ta_unload_debugfs_dentry;

static struct dentry *ta_invoke_debugfs_dentry;

#if defined(CONFIG_DEBUG_FS)



static ssize_t ta_if_load_debugfs_write(struct file *fp, const char *buf,

					    size_t len, loff_t *off);
@@ -38,7 +33,6 @@ static ssize_t ta_if_unload_debugfs_write(struct file *fp, const char *buf, 
static ssize_t ta_if_invoke_debugfs_write(struct file *fp, const char *buf,

					    size_t len, loff_t *off);





static uint32_t get_bin_version(const uint8_t *bin)

{

	const struct common_firmware_header *hdr =
@@ -286,31 +280,25 @@ static ssize_t ta_if_invoke_debugfs_write(struct file *fp, const char *buf, size 
	return ret;

}



static struct dentry *amdgpu_ta_if_debugfs_create(struct amdgpu_device *adev)

void amdgpu_ta_if_debugfs_init(struct amdgpu_device *adev)

{

	struct drm_minor *minor = adev_to_drm(adev)->primary;



	dir = debugfs_create_dir(TA_IF_FS_NAME, minor->debugfs_root);

	struct dentry *dir = debugfs_create_dir("ta_if", minor->debugfs_root);



	ta_load_debugfs_dentry = debugfs_create_file("ta_load", 0200, dir, adev,

	debugfs_create_file("ta_load", 0200, dir, adev,

				     &ta_load_debugfs_fops);



	ta_unload_debugfs_dentry = debugfs_create_file("ta_unload", 0200, dir,

	debugfs_create_file("ta_unload", 0200, dir,

				     adev, &ta_unload_debugfs_fops);



	ta_invoke_debugfs_dentry = debugfs_create_file("ta_invoke", 0200, dir,

	debugfs_create_file("ta_invoke", 0200, dir,

				     adev, &ta_invoke_debugfs_fops);

	return dir;

}



#else

void amdgpu_ta_if_debugfs_init(struct amdgpu_device *adev)

{

#if defined(CONFIG_DEBUG_FS)

	dir = amdgpu_ta_if_debugfs_create(adev);

#endif

}



void amdgpu_ta_if_debugfs_remove(void)

{

	debugfs_remove_recursive(dir);

}

#endif

drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.h

+0 −1
Original line number Diff line number Diff line
@@ -25,6 +25,5 @@ 
#define __AMDGPU_PSP_TA_H__



void amdgpu_ta_if_debugfs_init(struct amdgpu_device *adev);

void amdgpu_ta_if_debugfs_remove(void);



#endif