Unverified Commit 86f3c055 authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Mark Brown
Browse files

ASoC: atmel: fix shadowed variable 



Fix cppcheck warning:

sound/soc/atmel/atmel-classd.c:51:14: style: Local variable 'pwm_type'
shadows outer variable [shadowVariable]
 const char *pwm_type;
             ^
sound/soc/atmel/atmel-classd.c:226:27: note: Shadowed declaration
static const char * const pwm_type[] = {
                          ^
sound/soc/atmel/atmel-classd.c:51:14: note: Shadow variable
 const char *pwm_type;
             ^

Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarCodrin Ciubotariu <codrin.ciubotariu@microchip.com>
Link: https://lore.kernel.org/r/20210326215927.936377-3-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 2711a2d9

sound/soc/atmel/atmel-classd.c

+3 −3
Original line number Diff line number Diff line
@@ -48,7 +48,7 @@ static struct atmel_classd_pdata *atmel_classd_dt_init(struct device *dev) 
{

	struct device_node *np = dev->of_node;

	struct atmel_classd_pdata *pdata;

	const char *pwm_type;

	const char *pwm_type_s;

	int ret;



	if (!np) {
@@ -60,8 +60,8 @@ static struct atmel_classd_pdata *atmel_classd_dt_init(struct device *dev) 
	if (!pdata)

		return ERR_PTR(-ENOMEM);



	ret = of_property_read_string(np, "atmel,pwm-type", &pwm_type);

	if ((ret == 0) && (strcmp(pwm_type, "diff") == 0))

	ret = of_property_read_string(np, "atmel,pwm-type", &pwm_type_s);

	if ((ret == 0) && (strcmp(pwm_type_s, "diff") == 0))

		pdata->pwm_type = CLASSD_MR_PWMTYP_DIFF;

	else

		pdata->pwm_type = CLASSD_MR_PWMTYP_SINGLE;