Commit 87e9b202 authored by Frederic Weisbecker's avatar Frederic Weisbecker
Browse files

hw-breakpoints: Check disabled breakpoints again 



We stopped checking disabled breakpoints because we weren't
allowing breakpoints on NULL addresses. And gdb tends to set
NULL addresses on inactive breakpoints.

But refusing NULL addresses was actually a regression that has
been fixed now. There is no reason anymore to not validate
inactive breakpoint settings.

Signed-off-by: default avatarFrederic Weisbecker <fweisbec@gmail.com>
Acked-by: default avatarPaul Mundt <lethal@linux-sh.org>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
Cc: K. Prasad <prasad@linux.vnet.ibm.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Jason Wessel <jason.wessel@windriver.com>
Cc: Ingo Molnar <mingo@elte.hu>
parent 73266fc1

kernel/hw_breakpoint.c

+1 −11
Original line number Diff line number Diff line
@@ -316,16 +316,6 @@ int register_perf_hw_breakpoint(struct perf_event *bp) 
	if (ret)

		return ret;



	/*

	 * Ptrace breakpoints can be temporary perf events only

	 * meant to reserve a slot. In this case, it is created disabled and

	 * we don't want to check the params right now (as we put a null addr)

	 * But perf tools create events as disabled and we want to check

	 * the params for them.

	 * This is a quick hack that will be removed soon, once we remove

	 * the tmp breakpoints from ptrace

	 */

	if (!bp->attr.disabled || !bp->overflow_handler)

	ret = arch_validate_hwbkpt_settings(bp, bp->ctx->task);



	/* if arch_validate_hwbkpt_settings() fails then release bp slot */