Commit 89151f6b authored Mar 10, 2023 by Rob Herring Committed by Wolfram Sang Mar 16, 2023

i2c: Use of_property_read_bool() for boolean properties



It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties.
Convert reading boolean properties to to of_property_read_bool().

Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Signed-off-by: Wolfram Sang <wsa@kernel.org>

parent 819c7345

drivers/i2c/busses/i2c-mpc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -842,7 +842,7 @@ static int fsl_i2c_probe(struct platform_device *op)
		data->setup(op->dev.of_node, i2c, clock);
		} else {
		/* Backwards compatibility */
		if (of_get_property(op->dev.of_node, "dfsrr", NULL))
		if (of_property_read_bool(op->dev.of_node, "dfsrr"))
		mpc_i2c_setup_8xxx(op->dev.of_node, i2c, clock);
		}

drivers/i2c/busses/i2c-pxa.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -1261,10 +1261,8 @@ static int i2c_pxa_probe_dt(struct platform_device pdev, struct pxa_i2c i2c,
		/* For device tree we always use the dynamic or alias-assigned ID */
		i2c->adap.nr = -1;

		if (of_get_property(np, "mrvl,i2c-polling", NULL))
		i2c->use_pio = 1;
		if (of_get_property(np, "mrvl,i2c-fast-mode", NULL))
		i2c->fast_mode = 1;
		i2c->use_pio = of_property_read_bool(np, "mrvl,i2c-polling");
		i2c->fast_mode = of_property_read_bool(np, "mrvl,i2c-fast-mode");

		*i2c_types = (enum pxa_i2c_types)(of_id->data);

drivers/i2c/i2c-core-of.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -55,7 +55,7 @@ int of_i2c_get_board_info(struct device dev, struct device_node node,
		if (of_property_read_bool(node, "host-notify"))
		info->flags \|= I2C_CLIENT_HOST_NOTIFY;

		if (of_get_property(node, "wakeup-source", NULL))
		if (of_property_read_bool(node, "wakeup-source"))
		info->flags \|= I2C_CLIENT_WAKE;

		return 0;