Commit 894b0432 authored by Alexandre Belloni's avatar Alexandre Belloni
Browse files

rtc: rx8010: remove RTC_VL_CLR handling 

Remove RTC_VL_CLR handling because it is a disservice to userspace as it
removes the important information that the RTC data is invalid. This may
lead userspace to set an invalid system time later on.

Link: https://lore.kernel.org/r/20191214220259.621996-17-alexandre.belloni@bootlin.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent bcd17c50

drivers/rtc/rtc-rx8010.c

+1 −15
Original line number Diff line number Diff line
@@ -389,9 +389,8 @@ static int rx8010_alarm_irq_enable(struct device *dev, 


static int rx8010_ioctl(struct device *dev, unsigned int cmd, unsigned long arg)

{

	struct i2c_client *client = to_i2c_client(dev);

	struct rx8010_data *rx8010 = dev_get_drvdata(dev);

	int ret, tmp;

	int tmp;

	int flagreg;



	switch (cmd) {
@@ -406,19 +405,6 @@ static int rx8010_ioctl(struct device *dev, unsigned int cmd, unsigned long arg) 


		return 0;



	case RTC_VL_CLR:

		flagreg = i2c_smbus_read_byte_data(rx8010->client, RX8010_FLAG);

		if (flagreg < 0) {

			return flagreg;

		}



		flagreg &= ~RX8010_FLAG_VLF;

		ret = i2c_smbus_write_byte_data(client, RX8010_FLAG, flagreg);

		if (ret < 0)

			return ret;



		return 0;



	default:

		return -ENOIOCTLCMD;

	}