Commit 8a1c24bb authored by Manivannan Sadhasivam's avatar Manivannan Sadhasivam
Browse files

bus: mhi: ep: Save channel state locally during suspend and resume 



During suspend and resume, the channel state needs to be saved locally.
Otherwise, the endpoint may access the channels while they were being
suspended and causing access violations.

Fix it by saving the channel state locally during suspend and resume.

Cc: <stable@vger.kernel.org> # 5.19
Fixes: e4b7b5f0 ("bus: mhi: ep: Add support for suspending and resuming channels")
Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: default avatarJeffrey Hugo <quic_jhugo@quicinc.com)>
Link: https://lore.kernel.org/r/20221228161704.255268-7-manivannan.sadhasivam@linaro.org


Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
parent 8d6a1fea

drivers/bus/mhi/ep/main.c

+2 −0
Original line number Diff line number Diff line
@@ -1122,6 +1122,7 @@ void mhi_ep_suspend_channels(struct mhi_ep_cntrl *mhi_cntrl) 


		dev_dbg(&mhi_chan->mhi_dev->dev, "Suspending channel\n");

		/* Set channel state to SUSPENDED */

		mhi_chan->state = MHI_CH_STATE_SUSPENDED;

		tmp &= ~CHAN_CTX_CHSTATE_MASK;

		tmp |= FIELD_PREP(CHAN_CTX_CHSTATE_MASK, MHI_CH_STATE_SUSPENDED);

		mhi_cntrl->ch_ctx_cache[i].chcfg = cpu_to_le32(tmp);
@@ -1151,6 +1152,7 @@ void mhi_ep_resume_channels(struct mhi_ep_cntrl *mhi_cntrl) 


		dev_dbg(&mhi_chan->mhi_dev->dev, "Resuming channel\n");

		/* Set channel state to RUNNING */

		mhi_chan->state = MHI_CH_STATE_RUNNING;

		tmp &= ~CHAN_CTX_CHSTATE_MASK;

		tmp |= FIELD_PREP(CHAN_CTX_CHSTATE_MASK, MHI_CH_STATE_RUNNING);

		mhi_cntrl->ch_ctx_cache[i].chcfg = cpu_to_le32(tmp);