Commit 8a55d64c authored by Sergio Paracuellos's avatar Sergio Paracuellos Committed by Linus Walleij
Browse files

pinctrl: ralink: rt2880: preserve error codes 



Some paths in probe function are returning '-EINVAL'
instead of preserve original code from called functions.
Change them to preserve all of them.

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarSergio Paracuellos <sergio.paracuellos@gmail.com>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20201213161721.6514-7-sergio.paracuellos@gmail.com


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 420cf17d

drivers/pinctrl/ralink/pinctrl-rt2880.c

+8 −4
Original line number Diff line number Diff line
@@ -315,6 +315,7 @@ static int rt2880_pinmux_probe(struct platform_device *pdev) 
{

	struct rt2880_priv *p;

	struct pinctrl_dev *dev;

	int err;



	if (!rt2880_pinmux_data)

		return -ENOTSUPP;
@@ -330,13 +331,16 @@ static int rt2880_pinmux_probe(struct platform_device *pdev) 
	platform_set_drvdata(pdev, p);



	/* init the device */

	if (rt2880_pinmux_index(p)) {

	err = rt2880_pinmux_index(p);

	if (err) {

		dev_err(&pdev->dev, "failed to load index\n");

		return -EINVAL;

		return err;

	}

	if (rt2880_pinmux_pins(p)) {



	err = rt2880_pinmux_pins(p);

	if (err) {

		dev_err(&pdev->dev, "failed to load pins\n");

		return -EINVAL;

		return err;

	}

	dev = pinctrl_register(p->desc, &pdev->dev, p);

	if (IS_ERR(dev))